Re: Ordering of header file inclusion

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Ordering of header file inclusion
Date: 2019-11-16 01:31:43
Message-ID: CALDaNm1ZW8RTBx-dhOLAgrQLizxkKkhauHruf6DthbYycf-RoA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 12, 2019 at 11:19 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Nov 12, 2019 at 6:33 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> >
> > Thanks Amit for your comments. Please find the updated patch which
> > does not include the changes mentioned above.
> >
>
> Thanks for working on this. I have pushed your latest patch.
>

Thanks Amit for pushing the patch. I have re-verified and found that
changes need to be done in few more places. The main changes are made
in the header file and plpython source files. The attached patch
handles the same. I have verified make check and make check-world
including --with-python & --with-perl in the following:
CentOS Linux release 7.7.1908
Red Hat Enterprise Linux Server release 7.1

I have verified including --llvm in CentOS Linux release 7.7.1908.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
0001-Make-the-order-of-the-header-file-includes-consistent-remaining-files.patch text/x-patch 44.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Dilger 2019-11-16 01:43:39 Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.
Previous Message Maciek Sakrejda 2019-11-16 01:04:52 Re: JIT performance bug/regression & JIT EXPLAIN