Re: Add FOREIGN to ALTER TABLE in pg_dump

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Luis Carril <luis(dot)carril(at)swarm64(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add FOREIGN to ALTER TABLE in pg_dump
Date: 2020-01-13 12:13:10
Message-ID: CALDaNm1Tthtu5SrXH7Uky3kdJAme8gHpePVxEdYGvsBpPHfBYA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 26, 2019 at 7:17 PM Luis Carril <luis(dot)carril(at)swarm64(dot)com> wrote:
>
>
> I don't disagree with adding FOREIGN, though.
>
> Your patch is failing the pg_dump TAP tests. Please use
> configure --enable-tap-tests, fix the problems, then resubmit.
>
> Fixed, I've attached a new version.

Will it be possible to add a test case for this, can we validate by
adding one test?

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2020-01-13 12:49:35 Re: pg_basebackup fails on databases with high OIDs
Previous Message Julien Rouhaud 2020-01-13 12:09:01 Re: isTempNamespaceInUse() is incorrect with its handling of MyBackendId