| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: pg_upgrade and logical replication |
| Date: | 2023-11-10 14:01:38 |
| Message-ID: | CALDaNm1TrLotw0kekXCSAcmVkAtqpyjpNQmVeXnLEimRbZO_ig@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 9 Nov 2023 at 07:44, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Thanks for addressing my previous review comments.
>
> I re-checked the latest patch v12-0001 and found the following:
>
> ======
> Commit message
>
> 1.
> The new SQL binary_upgrade_create_sub_rel_state function has the following
> syntax:
> SELECT binary_upgrade_create_sub_rel_state(subname text, relid oid,
> state char [,sublsn pg_lsn])
>
> ~
>
> Looks like v12 accidentally forgot to update this to the modified
> function name 'binary_upgrade_add_sub_rel_state'
This is handled in the v13 version patch posted at:
https://www.postgresql.org/message-id/CALDaNm0mGz6_69BiJTmEqC8Q0U0x2nMZOs3w9btKOHZZpfC2ow%40mail.gmail.com
Regards,
Vignesh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2023-11-10 14:26:51 | Re: ResourceOwner refactoring |
| Previous Message | vignesh C | 2023-11-10 13:56:18 | Re: pg_upgrade and logical replication |