| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH]Comment improvement in publication.sql |
| Date: | 2021-12-13 15:52:57 |
| Message-ID: | CALDaNm1P6hdJT-wkURo=Wc3m9Sqn7aNf6a6wqFg7uF1MTbab9Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 8, 2021 at 11:07 AM tanghy(dot)fnst(at)fujitsu(dot)com
<tanghy(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Wednesday, December 8, 2021 1:49 PM, vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> > The patch no longer applies, could you post a rebased patch.
>
> Thanks for your kindly reminder. Attached a rebased patch.
> Some changes in v4 patch has been fixed by 5a28324, so I deleted those changes.
Thanks for the updated patch, should we make a similar change in
AlterPublicationTables Function header to mention Set too:
/*
* Add or remove table to/from publication.
*/
static void
AlterPublicationTables(AlterPublicationStmt *stmt, HeapTuple tup,
List *tables, List *schemaidlist)
Regards,
Vignesh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-12-13 16:00:11 | Re: Remove pg_strtouint64(), use strtoull() directly |
| Previous Message | Tom Lane | 2021-12-13 15:46:39 | Re: Remove pg_strtouint64(), use strtoull() directly |