| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Review items for EXCEPT TABLE publication |
| Date: | 2026-09-11 09:43:13 |
| Message-ID: | CALDaNm1H0_AVLjKN1k8sqcpRMuxkjMG-hK_Z7jc7JLsAxaP=rQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 11 Sept 2026 at 13:57, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> I don't really see what is gained by splitting those error messages,
> since the user will get an indeterminate one, and either way they have
> to fix it
>
> IMO, a single unified message could be a simpler/better choice here:
>
> e.g.
>
> ereport(ERROR,
> (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
> errmsg("cannot change table \"%s\" to unlogged because it is
> referenced by a publication",
> RelationGetRelationName(rel)),
> errdetail("Unlogged relations cannot be published or excluded via
> an EXCEPT clause."),
> errhint("Remove the table from the publication first.")));
I agree with this approach. A single unified error message is better,
especially since the user needs to remove the table from the
publication either way.
Regards,
Vignesh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2026-09-11 09:43:15 | Re: Race conditions in logical decoding |
| Previous Message | Amit Langote | 2026-09-11 09:25:28 | Re: PG19: two RI fast-path issues found while testing the batching revert |