| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Is ParsePrepareRecord dead function |
| Date: | 2019-07-29 16:03:31 |
| Message-ID: | CALDaNm14Uk0Gdpj02trUJUJ8W3Ow6Jh3jqwNb0Ln9hHAZUL0ng@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 29, 2019 at 8:24 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Mon, Jul 29, 2019 at 4:10 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > I could not locate the caller of ParsePrepareRecord function in twophase.c.
> > Any idea how it gets called?
> > or
> > Is it a dead function?
>
> It looks like it's not only dead, but stillborn. Commit
> 1eb6d6527aae264b3e0b9c95aa70bb7a594ad1cf introduced it but without
> introducing any code that called it, and nothing has changed since
> then.
>
I feel the code can be safely removed.
Patch for the same is attached.
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| 001_Unused_function_ParsePrepareRecord_removal.patch | application/octet-stream | 2.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2019-07-29 16:11:27 | Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS) |
| Previous Message | Tom Lane | 2019-07-29 15:40:12 | Re: benchmarking Flex practices |