Re: Added tab completion for the missing options in copy statement

On Sat, Jun 27, 2020 at 6:52 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Hi,
>
> I found that tab completion for some parts of the copy statement was
> missing. The Tab completion was missing for the following cases:
> 1) COPY [BINARY] <sth> FROM filename -> "BINARY", "DELIMITER", "NULL",
> "CSV", "ENCODING", "WITH (", "WHERE" should be shown.
> 2) COPY [BINARY] <sth> TO filename -> "BINARY", "DELIMITER", "NULL",
> "CSV", "ENCODING", "WITH (" should be shown.
> 3) COPY [BINARY] <sth> FROM filename WITH options -> "WHERE" should be shown.
>
> I could not find any test cases for tab completion, hence no tests
> were added. Attached a patch which has the fix for the same.
> Thoughts?
>

>The following review has been posted through the commitfest application:
>make installcheck-world: tested, passed
>Implements feature: tested, passed
>Spec compliant: tested, passed
>Documentation: not tested
>Tested the tab complete for copy command, it provides the tab completion after providing the "TO|FROM filename With|Where". Does this require any doc change?

Thanks for reviewing the patch.
This changes is already present in the document, no need to make any
changes as shown below:

COPY table_name [ ( column_name [, ...] ) ]
FROM { 'filename' | PROGRAM 'command' | STDIN }
[ [ WITH ] ( option [, ...] ) ]
[ WHERE condition ]

Please have a look and let me know if you feel anything needs to be
added on top of it.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com