| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, YeXiu <1518981153(at)qq(dot)com>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Skipping schema changes in publication |
| Date: | 2026-02-28 08:13:15 |
| Message-ID: | CALDaNm11zmAdSg2vOrGJ6KnB3hX34Pd1r2NU7nTXJpN6f-7tqQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 26 Feb 2026 at 19:41, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Feb 25, 2026 at 10:43 PM Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> wrote:
> >
> > I have also split the patch 0002 to 0002 and 0003
> > 0001 - Support CREATE PUBLICATION ... EXCEPT TABLE syntax
> >
>
> Few comments:
> =============
> *
> * pub_all_obj_type is one of:
> *
> - * TABLES
> + * TABLES [EXCEPT [TABLE] ( table [, ...] )]
> As per above syntax in gram.y, [TABLE] is optional but won't it be
> confusing when we also support sequences? Then we need to identify
> whether the object given in EXCEPT list is table or sequence. So, I
> think it is better to keep TABLE as non-optional.
>
> * Can we have one test related to INHERITS for actual replication
> unless it is already there?
Thanks for the comments, these comments are addressed in the v52
version patch attached.
Also the comments from [1] are addressed in the same.
[1] - https://www.postgresql.org/message-id/CAA4eK1JrqoPvrFxZEO2rB%3D-jXK1BQdJZz2_2oeZqCQR3GRWC2g%40mail.gmail.com
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v52-0001-Skip-publishing-the-tables-specified-in-EXCEPT-T.patch | application/octet-stream | 77.5 KB |
| v52-0003-Support-DROP-EXCEPT-TABLE-in-ALTER-PUBLICATION.patch | application/octet-stream | 10.5 KB |
| v52-0002-Support-SET-EXCEPT-TABLE-in-ALTER-PUBLICATION.patch | application/octet-stream | 20.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | James Pang | 2026-02-28 08:26:05 | Re: Primary and standby setting cross-checks |
| Previous Message | Yura Sokolov | 2026-02-28 07:43:49 | Re: Fix bug in multixact Oldest*MXactId initialization and access |