| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, YeXiu <1518981153(at)qq(dot)com>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Skipping schema changes in publication |
| Date: | 2026-02-26 14:11:31 |
| Message-ID: | CAA4eK1+bBvo3_qE+Y=zLmR+E97KhVseuWrxako=dhzWtVyouXg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 25, 2026 at 10:43 PM Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> wrote:
>
> I have also split the patch 0002 to 0002 and 0003
> 0001 - Support CREATE PUBLICATION ... EXCEPT TABLE syntax
>
Few comments:
=============
*
* pub_all_obj_type is one of:
*
- * TABLES
+ * TABLES [EXCEPT [TABLE] ( table [, ...] )]
As per above syntax in gram.y, [TABLE] is optional but won't it be
confusing when we also support sequences? Then we need to identify
whether the object given in EXCEPT list is table or sequence. So, I
think it is better to keep TABLE as non-optional.
* Can we have one test related to INHERITS for actual replication
unless it is already there?
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nisha Moond | 2026-02-26 14:13:12 | Re: [PATCH] Support automatic sequence replication |
| Previous Message | Fujii Masao | 2026-02-26 14:10:02 | Re: doc: Clarify that empty COMMENT string removes the comment |