From: | vignesh C <vignesh21(at)gmail(dot)com> |
---|---|
To: | "Karl O(dot) Pinc" <kop(at)karlpinc(dot)com> |
Cc: | Brar Piening <brar(at)gmx(dot)de>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: doc: add missing "id" attributes to extension packaging page |
Date: | 2023-01-09 02:38:22 |
Message-ID: | CALDaNm0sha+w3TGppSCVuiBUA_njJx_6nv8mY8R2Trbu37S5rw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, 9 Jan 2023 at 08:01, vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Wed, 4 Jan 2023 at 04:13, Karl O. Pinc <kop(at)karlpinc(dot)com> wrote:
> >
> > On Tue, 3 Jan 2023 21:35:09 +0100
> > Brar Piening <brar(at)gmx(dot)de> wrote:
> >
> > > On 02.01.2023 at 21:53, Karl O. Pinc wrote:
> > > > If the author will look over my version of the patch I believe it
> > > > can be approved and sent on to the committers.
> > >
> > > LGTM.
> >
> > Approved for committer!
>
> The patch does not apply on top of HEAD as in [1], please post a rebased patch:
> === Applying patches on top of PostgreSQL commit ID
> cd9479af2af25d7fa9bfd24dd4dcf976b360f077 ===
> === applying patch ./add_html_ids_v2.patch
> ....
> patching file doc/src/sgml/ref/pgbench.sgml
> patching file doc/src/sgml/ref/psql-ref.sgml
> Hunk #73 FAILED at 1824.
> ....
> 2 out of 208 hunks FAILED -- saving rejects to file
> doc/src/sgml/ref/psql-ref.sgml.rej
>
> [1] - http://cfbot.cputube.org/patch_41_4041.log
There are couple of commitfest entries for this:
https://commitfest.postgresql.org/41/4041/
https://commitfest.postgresql.org/41/4042/
Can one of them be closed?
Regards,
Vignesh
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2023-01-09 02:43:59 | Re: Fixing a couple of buglets in how VACUUM sets visibility map bits |
Previous Message | vignesh C | 2023-01-09 02:31:37 | Re: doc: add missing "id" attributes to extension packaging page |