Re: Ordering of header file inclusion

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Ordering of header file inclusion
Date: 2019-11-02 02:12:06
Message-ID: CALDaNm0m=XJzGrN0B13+93QngkY=_ByFgA-12i5u8J9ev2O=DQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 25, 2019 at 3:28 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, Oct 24, 2019 at 2:43 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Wed, Oct 23, 2019 at 10:23 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > > Attached are patches for (a) and (b) after another round of review and
> > > fixes by Vignesh. I am planning to commit the first one (a) tomorrow
> > > morning and then if everything is fine on buildfarm, I will commit the
> > > second one (b) and once both are good, I will look into the third one
> > > (c). Another pair of eyes on these patches would be good.
> > >
> >
> > I have pushed the first one. I'll wait for some time and probably
> > commit the second one tomorrow.
> >
>
> I have committed the second one as well. Now, the remaining patch is
> for the entire backend. I will pick it up after a few days.
>
Thanks Amit for committing the changes.
I found couple of more inconsistencies, the attached patch includes
the fix for the same.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
0001-Make-the-order-of-the-header-file-includes-consistent-backend.patch text/x-patch 121.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-11-02 02:21:18 Re: Make StringInfo available to frontend code.
Previous Message Tom Lane 2019-11-01 22:26:15 Re: Rearranging ALTER TABLE to avoid multi-operations bugs