Re: sequencesync worker race with REFRESH SEQUENCES

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: sequencesync worker race with REFRESH SEQUENCES
Date: 2026-07-30 10:46:26
Message-ID: CALDaNm0iuFC6PJ=b0jx-u3SC4qEJMjNbU7K4MaZMM8fW30t3WA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 30 Jul 2026 at 04:07, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> FYI, somehow the "rather than" wording of the above comment became a
> "rathen then" typo in the master code [1].

Thanks for reporting this. The attached patch addresses the issue.

In addition, it also addresses the last remaining finding (Finding 13:
"REFRESH SEQUENCES warning misattributes a `copy_data` request the
command cannot express"). The warning emitted by
check_publications_origin_sequences() is triggered when a subscription
with origin = NONE synchronizes sequence values that may have
originated from another subscription. However, the existing warning is
phrased in terms of copy_data and copying data, which is appropriate
for table synchronization but misleading for sequence synchronization.
The patch rewords the warning, detail, and hint to describe sequence
synchronization and the associated origin = NONE semantics more
accurately.

Regards,
Vignesh

Attachment Content-Type Size
0001-Improve-wording-of-sequence-origin-warning-in-logica.patch application/octet-stream 3.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hannu Krosing 2026-07-30 10:58:51 Re: Direct Toast PoC
Previous Message Nikita Malakhov 2026-07-30 09:47:20 Re: Direct Toast PoC