From: | vignesh C <vignesh21(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Added missing tab completion for alter subscription set option |
Date: | 2021-05-19 14:28:04 |
Message-ID: | CALDaNm0hzq3snLhSWb_-aoCd4Ym8FcNrcNm7FUkUTTfrRG2rNg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, May 18, 2021 at 9:20 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2021-May-14, vignesh C wrote:
>
> > While I was reviewing one of the logical decoding features, I found
> > Streaming and binary options were missing in tab completion for the
> > alter subscription set option, the attached patch has the changes for
> > the same.
> > Thoughts?
>
> I wish we didn't have to keep knowledge in the psql source on which
> option names are to be used for each command. If we had some function
> SELECT pg_completion_options('alter subscription set');
> that returned the list of options usable for each command, we wouldn't
> have to ... psql would just retrieve the list of options for the current
> command.
>
> Maintaining such a list does not seem hard -- for example we could just
> have a function alongside parse_subscription_option() that returns the
> names that are recognized by that one. If we drive the implementation
> of both off a single struct, it would never be outdated.
>
I like the idea of maintaining a common list, that will also prevent
options getting missed in the future. I will work on this and provide
a patch for it.
Regards,
Vignesh
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2021-05-19 14:31:35 | Re: Improve documentation for pg_upgrade, standbys and rsync |
Previous Message | Christoph Berg | 2021-05-19 14:18:54 | Freenode woes |