| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Typos and inconsistencies in code |
| Date: | 2019-10-30 03:50:16 |
| Message-ID: | CALDaNm0hLN=yjqnQFOS9wdtr4Npsx1i2fc9OB3m5tA22m=kDUg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 30, 2019 at 6:35 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Tue, Oct 29, 2019 at 05:27:20PM +0530, vignesh C wrote:
> > I have attached the updated patch with the fixes.
>
> The changes in rangetypes_gist.c are not correct, the usual pattern to
> add an "s" after the structure name is quite common when referring to
> multiple elements. We could perhaps use "put-your-struct entries"
> instead, but I have seen the pattern of HEAD quite a lot as well (see
> also for example mcv.c with SortItem that is a file your patch
> touches).
>
> A comment indentation was wrong in detoast.c, not the fault of this
> patch but I have fixed it at the same time.
>
Thanks for pushing the changes Michael.
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2019-10-30 04:08:00 | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |
| Previous Message | Kyotaro Horiguchi | 2019-10-30 03:34:28 | Re: Problem with synchronous replication |