Re: Logical replication row filter loses unchanged toasted columns

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Shinya Kato <shinya11(dot)kato(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Logical replication row filter loses unchanged toasted columns
Date: 2026-09-03 10:38:38
Message-ID: CALDaNm0bSmQqaybnx1VXLGk_Tsk-B8Tqe5=4A3XrZe7BM=dBiA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 2 Sept 2026 at 06:05, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Tue, Sep 1, 2026 at 4:55 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > Agreed that the allocation of more than 1GB for a single row is our
> > limitation besides the bug-fix patch we are discussing as can be seen
> > by both INSERT/UPDATE cases. Though UPDATE case is slightly different
> > as there we are generating such a large tuple (by fetching the entire
> > toast tuple data to WAL log as old_tuple) for the REPLICA IDENTIFY
> > FULL case, so one could expect it to work. So, if we want to leave
> > this limitation for UPDATE/INSERT as it is and just document it (if
> > not documented already) then it is okay to proceed with the current
> > approach to fix the issue reported by adding another case to the
> > limitation.
>
> +1
>

Added a documentation to mention about this limitation, the attached
v6 version patch has the changes for the same.

Regards,
Vignesh

Attachment Content-Type Size
v6-0001-Log-unchanged-out-of-line-columns-for-row-filtere.patch application/octet-stream 23.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Zsolt Parragi 2026-09-03 10:38:44 pg_stat_progress_cluster: do not default to CLUSTER
Previous Message Jan Nidzwetzki 2026-09-03 10:03:54 Re: Many of psql's describe functions bloat cache / waste mem