| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Performance Improvement For Copy From Binary Files |
| Date: | 2020-07-15 04:06:23 |
| Message-ID: | CALDaNm0_H+DZN60FuxruUmYBffv56tMMsT2EMcc5QPr0kqsxGA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 15, 2020 at 8:03 AM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
>
> Hi Vignesh,
>
> On Tue, Jul 14, 2020 at 10:23 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > On Tue, Jul 14, 2020 at 11:19 AM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > > Sounds fine to me. Although CopyLoadRawBuf() does not seem to a
> > > candidate for rigorous code optimization as it does not get called
> > > that often.
> >
> > I thought we could include that change as we are making changes around
> > that code.
>
> Sure, done.
>
> > Rest of the changes looked fine to me. Also I noticed that
> > commit message was missing in the patch.
>
> Please see the attached v7.
>
Thanks for fixing the comments.
Patch applies cleanly, make check & make check-world passes.
The changes looks fine to me.
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2020-07-15 04:12:35 | Re: Default setting for enable_hashagg_disk |
| Previous Message | Dilip Kumar | 2020-07-15 04:05:09 | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |