| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Handle infinite recursion in logical replication setup |
| Date: | 2022-06-06 05:14:08 |
| Message-ID: | CALDaNm0Haovukx2q7Yd987Sm8fbQ0nsh8F0EWaO_qsw0uObGBQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 3, 2022 at 10:56 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Please find below my review comments for patch v17-0001:
>
> ======
>
> 1. Commit message
> Add a missing test to verify only-local option in test_decoding plugin.
>
> "option" -> "parameter"
Modified
> ======
>
> 2. contrib/test_decoding/sql/replorigin.sql
>
> 2a.
> +-- Verify that remote origin data is not returned with only-local option
>
> SUGGESTION
> -- Verify the behaviour of the only-local parameter
Modified
> 2b.
> +-- Remote origin data returned when only-local option is not set
>
> "option" -> "parameter"
Modified
> 2c.
> +-- Remote origin data not returned when only-local option is set
>
> "option" -> "parameter"
Modified
The attached v18 patch has the fixes for the same.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v18-0001-Add-a-missing-test-to-verify-only-local-paramete.patch | text/x-patch | 4.3 KB |
| v18-0002-Skip-replication-of-non-local-data.patch | text/x-patch | 54.7 KB |
| v18-0003-Check-and-throw-an-error-if-publisher-tables-wer.patch | text/x-patch | 37.9 KB |
| v18-0004-Document-bidirectional-logical-replication-steps.patch | text/x-patch | 13.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2022-06-06 05:17:09 | Re: Handle infinite recursion in logical replication setup |
| Previous Message | Michael Paquier | 2022-06-06 04:58:40 | Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set |