| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Handle infinite recursion in logical replication setup |
| Date: | 2022-06-03 05:26:29 |
| Message-ID: | CAHut+PtPmLQfnO8j5YahiDrf6Lj04H3d=ncYxVuxBp2A=FDLWA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Please find below my review comments for patch v17-0001:
======
1. Commit message
Add a missing test to verify only-local option in test_decoding plugin.
"option" -> "parameter"
======
2. contrib/test_decoding/sql/replorigin.sql
2a.
+-- Verify that remote origin data is not returned with only-local option
SUGGESTION
-- Verify the behaviour of the only-local parameter
2b.
+-- Remote origin data returned when only-local option is not set
"option" -> "parameter"
2c.
+-- Remote origin data not returned when only-local option is set
"option" -> "parameter"
------
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2022-06-03 05:30:49 | Re: Handle infinite recursion in logical replication setup |
| Previous Message | Peter Geoghegan | 2022-06-03 04:35:34 | Re: some aspects of our qsort might not be ideal |