| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Luis Carril <luis(dot)carril(at)swarm64(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add FOREIGN to ALTER TABLE in pg_dump |
| Date: | 2020-01-14 00:32:56 |
| Message-ID: | CALDaNm0CQ5ASGSnipH-rnPg3W1zYzX+V7tK3DXexCd_7it+W6Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 13, 2020 at 7:52 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> vignesh C <vignesh21(at)gmail(dot)com> writes:
> > On Thu, Sep 26, 2019 at 7:17 PM Luis Carril <luis(dot)carril(at)swarm64(dot)com> wrote:
> >>> Your patch is failing the pg_dump TAP tests. Please use
> >>> configure --enable-tap-tests, fix the problems, then resubmit.
>
> >> Fixed, I've attached a new version.
>
> > Will it be possible to add a test case for this, can we validate by
> > adding one test?
>
> Isn't the change in the TAP test output sufficient?
>
I could not see any expected file output changes in the patch. Should
we modify the existing test to validate this.
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2020-01-14 00:48:21 | Re: Option to dump foreign data in pg_dump |
| Previous Message | Tom Lane | 2020-01-14 00:27:05 | Re: DROP OWNED CASCADE vs Temp tables |