| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Greg Burd <greg(at)burd(dot)me>, Hayato Kuroda <kuroda(dot)hayato(at)fujitsu(dot)com>, Joao Rito <joaovictor(dot)rito(at)gmail(dot)com>, shihao zhong <zhong950419(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Jeff Davis <pgsql(at)j-davis(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Hash index: stop registering pin-only bucket pages in WAL (remove REGBUF_NO_CHANGE) |
| Date: | 2026-11-18 08:33:51 |
| Message-ID: | CALDaNm0AEUYDUQn+mpfZB4R17Wxkjv4xAFUGitERQOo2PnCWBg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 18 Nov 2026 at 12:43, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Nov 18, 2026 at 1:51 AM Greg Burd <greg(at)burd(dot)me> wrote:
> >
> > Amit, Vignesh,
> >
> > Agreed, and thanks Vignesh for splitting it out. v13 is what I had in
> > mind: the torn-page read fix on its own, backpatchable, with the
> > recovery test and the HEAD-only rework (dropping the pin-only
> > registration, removing REGBUF_NO_CHANGE) left for a separate commit on
> > master once this is in.
> >
>
> Pushed. Next, I suggest we can work on the patch for "dropping the
> pin-only registration". Once that is committed, we can move to
> removing REGBUF_NO_CHANGE.
Thanks for pushing this patch, here is the rebased patch for the
pin-only registration changes.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v13-0001-Don-t-register-pin-only-primary-bucket-pages-in-.patch | application/octet-stream | 23.2 KB |
| v13-0002-Add-a-recovery-test-for-the-hash-WAL-pin-only-bu.patch | application/octet-stream | 11.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Steven Niu | 2026-11-18 08:34:53 | Re: Fix exclusion of the init fork in table_block_relation_size() |
| Previous Message | Akshay Joshi | 2026-11-18 08:32:40 | Re: [PATCH] Add pg_get_table_ddl() to reconstruct CREATE TABLE statements |