Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Amul Sul <sulamul(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid
Date: 2026-04-16 14:12:07
Message-ID: CALDaNm03644=iewXg85BU5Kg+RWyk97BYOappjR6ojn25f4Mcg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 16 Apr 2026 at 19:36, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Thu, Apr 16, 2026 at 9:31 PM Amul Sul <sulamul(at)gmail(dot)com> wrote:
> > The outer parentheses do not seem to be needed, as
> > XLogRecPtrIsInvalid() already includes them.
> >
> > Other than that, the v3 patch looks good to me.
>
> I've updated the patch based on Amul's suggestion and pushed it. Thanks!

Thanks for pushing the patch.

Regards,
Vignesh

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2026-04-16 14:33:23 Re: Do we still need gen_node_support.pl's nodetag ABI stability check?
Previous Message Álvaro Herrera 2026-04-16 14:10:33 Re: EXCEPT TABLE - Case inconsistency for describe \d and \dRp+