| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Shinya11(dot)Kato(at)nttdata(dot)com, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: psql - factor out echo code |
| Date: | 2021-07-10 14:49:13 |
| Message-ID: | CALDaNm007JDVCYgpKnaYC6zYO+JBWfqsNUpum6ZOD3AjU0Z=qw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jul 3, 2021 at 3:07 AM Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
>
>
> > "-- # <whatever> QUERY\n%s\n\n"
>
> Attached an attempt along those lines. I found another duplicate of the
> ascii-art printing in another function.
>
> Completion queries seems to be out of the echo/echo hidden feature.
>
> Incredible, there is a (small) impact on regression tests for the \gexec
> case. All other changes have no impact, because they are not tested:-(
I am changing the status to "Needs review" as the review is not
completed for this patch and also there are some tests failing, that
need to be fixed:
test test_extdepend ... FAILED 50 ms
Regards,
Vignesh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-07-10 15:01:12 | Re: pgsql: Fix numeric_mul() overflow due to too many digits after decimal |
| Previous Message | John Naylor | 2021-07-10 13:49:58 | Re: Reduce lock level for ALTER TABLE ... ADD CHECK .. NOT VALID |