From: | David Gilman <davidgilman1(at)gmail(dot)com> |
---|---|
To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Note new NULLS NOT DISTINCT on unique index tutorial page |
Date: | 2023-04-20 00:03:46 |
Message-ID: | CALBH9DB-vMpbxgA2oExZvQPDVGVvO5rzJ1dfcESfKawL0QeShg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
The revised patch is good. Please go ahead and commit whatever
phrasing you or the other committers find acceptable. I don't really
have any preferences in how this is exactly phrased, I just think it
should be mentioned in the docs.
On Mon, Apr 17, 2023 at 11:15 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Thu, 13 Apr 2023 at 02:40, David Gilman <davidgilman1(at)gmail(dot)com> wrote:
> > The SQL Language part of the docs has a brief page on unique indexes.
> > It doesn't mention the new NULLS NOT DISTINCT functionality on unique
> > indexes and this is a good place to mention it, as it already warns
> > the user about the old/default behavior.
>
> I think we should do this and apply it to v15 too.
>
> It seems like a good idea to include the [NULLS [NOT] DISTINCT] in the
> syntax synopsis too. Otherwise, the reader of that page is just left
> guessing where they'll put NULLS NOT DISTINCT to get the behaviour
> you've added the text for.
>
> I've attached an updated patch with that plus 2 very small wording
> tweaks to your proposed text.
>
> David
--
David Gilman
:DG<
From | Date | Subject | |
---|---|---|---|
Next Message | Justin Pryzby | 2023-04-20 00:41:35 | Re: Wrong results from Parallel Hash Full Join |
Previous Message | Peter Geoghegan | 2023-04-19 23:46:11 | Re: Should we put command options in alphabetical order in the doc? |