| From: | Surafel Temesgen <surafel3000(at)gmail(dot)com> |
|---|---|
| To: | Luis Carril <luis(dot)carril(at)swarm64(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Option to dump foreign data in pg_dump |
| Date: | 2019-09-19 06:38:03 |
| Message-ID: | CALAY4q_KZtdTY60rYJnpbpQcqfKqdspOmoO+RKW=DgvJJHapiA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Luis,
Here is a few comment for me
*I suggest the option to be just –foreign-data because if we make it
–include-foreign-data its expected to have –exclude-foreign-data option
too.
*please add test case
* + if (tdinfo->filtercond || tbinfo->relkind == RELKIND_FOREIGN_TABLE)
filter condition is not implemented completely yet so the logic only work
on foreign table so I think its better to handle it separately
* I don’t understand the need for changing SELECT query .we can use the
same SELECT query syntax for both regular table and foreign table
regards
Surafel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-09-19 07:37:04 | Re: ecpglib major version changed |
| Previous Message | Amit Kapila | 2019-09-19 06:17:23 | Re: pgbench - allow to create partitioned tables |