Re: Support to COMMENT ON DATABASE CURRENT_DATABASE

From: Surafel Temesgen <surafel3000(at)gmail(dot)com>
To: Jing Wang <jingwangian(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Support to COMMENT ON DATABASE CURRENT_DATABASE
Date: 2017-06-16 07:29:49
Message-ID: CALAY4q83yJhmX_a0go_Tg=tB=B7wVC-wpL4HQbVPfBOTMraUiQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 5, 2017 at 4:09 AM, Jing Wang <jingwangian(at)gmail(dot)com> wrote:

> Hi all,
>
> The attached patch is to support the feature "COMMENT ON DATABASE
> CURRENT_DATABASE". The solution is based on the previous discussion in [2] .
>

Your patch doesn't cover security labels on databases which have similar
issue
and consider dividing the patch into two one for adding CURRENT_DATABASE as
a
database specifier and the other for adding database-level information to
pg_dump output
in a way that allows to load a dump into a differently named database

Regards,

Surafel

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2017-06-16 07:38:14 Re: logical replication: \dRp+ and "for all tables"
Previous Message Tatsuo Ishii 2017-06-16 07:00:56 Restrictions of logical replication