Re: [PATCH v1] Fix initial sync of zero-column published tables

Hi Peter, Vignesh,

Thanks for the review. Attached is v3, based on the same master commit:
77705d1e5a616339c3e92f586bbfa7b6bb562beb.

Vignesh wrote:
> 1) Can we create the table in publisher and subscriber outside the
> loop instead of doing it twice, similarly the publication can be
> created outside the loop:

Done.

> 2) With the first changes, we can truncate the tables instead of dropping them:

Done. The subscription is dropped before truncating the tables between
modes. Each mode still checks initial sync and an incremental insert.

Peter wrote:
> Saying publish = 'insert' seems overkill.

Removed.

> Those could be combined a bit...

I've combined the cleanup and tidied the comments, spacing and
semicolons as suggested in your attachment. The C code is unchanged
from v2.

Vignesh wrote:
> 3) Till which branch will this patch be applied?

I reproduced the text-mode issue on PG10. I haven't reproduced it on
the other versions, but the code appears to have the same problem.
The binary case appears to be affected from PG16, which added binary
initial sync.

I think we should backpatch to the affected supported branches. I have
only tested the patch on master so far.

I tested v3 on master with assertions enabled. The regression tests and
the relevant logical replication tests passed.

Best regards,
mingjiegao