Re: DSA failed to allocate memory

From: Dongming Liu <ldming101(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: DSA failed to allocate memory
Date: 2022-03-18 07:30:49
Message-ID: CAL1p7e_cP9yBE2xbrXXqG4aVGs2d_TQ_WuW7JH9g1RrX-yUV_A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
> So it's OK for a segment to be in a bin that suggests that it has more
> consecutive free pages than it really does. But it's NOT ok for a
> segment to be in a bin that suggests it has fewer consecutive pages
> than it really does. If dsa_free() is putting things back into the
> wrong place, that's what we need to fix.

I'm trying to move segments into appropriate bins in dsa_free().
In 0001-Re-bin-segment-when-dsa-memory-is-freed.patch, I extract
the re-bin segment logic into a separate function called rebin_segment,
call it to move the segment to the appropriate bin when dsa memory is
freed. Otherwise, when allocating memory, due to the segment with
enough contiguous pages is in a smaller bin, a suitable segment
may not be found to allocate memory.

Fot test, I port the test_dsa patch from [1] and add an OOM case to
test memory allocation until OOM, free and then allocation, compare
the number of allocated memory before and after.

Any thoughts?

[1]
https://www.postgresql.org/message-id/CAEepm%3D3U7%2BRo7%3DECeQuAZoeFXs8iDVX56NXGCV7z3%3D%2BH%2BWd0Sw%40mail.gmail.com

Attachment Content-Type Size
0001-port-test_dsa.patch application/octet-stream 16.1 KB
0001-Re-bin-segment-when-dsa-memory-is-freed.patch application/octet-stream 4.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-03-18 07:38:57 Re: [PATCH] Accept IP addresses in server certificate SANs
Previous Message Noah Misch 2022-03-18 07:28:37 Re: Replication slot drop message is sent after pgstats shutdown.