| From: | Юрий Соколов <funny(dot)falcon(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Claudio Freire <klaussfreire(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Sokolov Yura <funny(dot)falcon(at)postgrespro(dot)ru>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL-Dev <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Small improvement to compactify_tuples |
| Date: | 2017-12-03 20:32:32 |
| Message-ID: | CAL-rCA2n7UfVu1Ui0f+7cVN4vAKVM0+-cZKb_ka6-mGQBAF92w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
hi,
On Wed, Nov 29, 2017 at 8:00 AM, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> On Tue, Nov 28, 2017 at 2:41 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> Maybe it's a stupid question. But would we still want to have this after
>> the change? These should be just specializations of the template version
>> imo.
"generic" version operates on bytes, and it will be a bit hard to combine
it with
templated version. Not impossible, but it will look ugly.
> I also wonder why regression test output has changed. Wasn't this
> supposed to be a mechanical change in how the templating is
> implemented? Why would the behavior of the algorithm change, even if
> the change is only a change in the output order among equal elements?
I did some change to algorithm then. But I reverted changes, and now no need
in test fixes.
> Also, is that one last raw CHECK_FOR_INTERRUPTS() in the template
> definition supposed to be there?
There was error. Fixed.
In attach fixed qsort_template version.
And version for compactify_tuples with bucket_sort and templated qsort.
With regards,
Sokolov Yura.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Header-for-customized-qsort.patch.gz | application/x-gzip | 6.2 KB |
| 0002-Bucket-sort-for-compactify_tuples.patch.gz | application/x-gzip | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2017-12-03 20:42:16 | Re: [HACKERS] postgres_fdw super user checks |
| Previous Message | Tom Lane | 2017-12-03 19:56:33 | Re: [HACKERS] postgres_fdw bug in 9.6 |