| From: | sirisha chamarthi <sirichamarthi22(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Fix comments atop pg_get_replication_slots |
| Date: | 2022-11-21 07:52:59 |
| Message-ID: | CAKrAKeVk-jbZ-KyRx-dqLnzB5SQr0A=1pdFEz4MdfschwCiQ0Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Amit, thanks for looking into this!
On Sun, Nov 20, 2022 at 11:38 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
wrote:
> On Mon, Nov 21, 2022 at 12:45 PM sirisha chamarthi
> <sirichamarthi22(at)gmail(dot)com> wrote:
> >
> > Hi Hackers,
> >
> > The comments atop seem to indicate that it is only showing active
> replication slots. The comment is ambiguous as it also shows all the slots
> including lost and inactive slots. Attached a small patch to fix it.
> >
>
> I agree that it is a bit confusing. How about "SQL SRF showing all
> replication slots that currently exist on the database cluster"?
>
Looks good to me. Attached a patch for the same.
>
> --
> With Regards,
> Amit Kapila.
>
| Attachment | Content-Type | Size |
|---|---|---|
| 0002-Fix-atop-pg_get_replication_slots-function-to-reflec.patch | application/octet-stream | 910 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chris Travers | 2022-11-21 07:58:00 | Re: Add 64-bit XIDs into PostgreSQL 15 |
| Previous Message | Simon Riggs | 2022-11-21 07:39:58 | Re: Reducing power consumption on idle servers |