Re: Parallel indicators not written by pg_get_functiondef

From: Feike Steenbergen <feikesteenbergen(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
Subject: Re: Parallel indicators not written by pg_get_functiondef
Date: 2016-04-27 07:02:05
Message-ID: CAK_s-G0kE43drFjx1w_rVSYU6BH5R51W92ofC6h-Xj7UeST_vA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

This patch is redundant as of
commit 2ac3be2e763d9b971352819f285dd51519e0aeb9

(Ashutosh Sharma diagnosed and patched the same problem)

On 15 April 2016 at 14:13, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
wrote:

> On Fri, Apr 15, 2016 at 8:48 PM, Feike Steenbergen
> <feikesteenbergen(at)gmail(dot)com> wrote:
> > pg_get_functiondef(oid) does not return the PARALLEL indicators.
> >
> > Attached a small patch to have pg_get_functiondef actually add these
> > indicators, using commit 7aea8e4f2 (pg_dump.c) as a guide.
> >
> > The logic is the same as with the volatility: we only append non-default
> > indicators.
>
> +1 for a good catch. Your patch is correct.
> --
> Michael
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christian Ullrich 2016-04-27 07:06:11 Re: Parallel build with MSVC
Previous Message Michael Paquier 2016-04-27 06:42:09 Re: Parallel build with MSVC