| From: | Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: pg_stat_get_activity(): integer overflow due to (int) * (int) for MemoryContextAllocHuge() |
| Date: | 2023-09-27 08:28:05 |
| Message-ID: | CAKZiRmzcDb0xsCiFWbQpB9AbyzjJpoHeagnoqcvip-VvszTUmQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 27, 2023 at 10:08 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Sep 27, 2023 at 08:41:55AM +0200, Jakub Wartak wrote:
> > Attached patch adjusts pgstat_track_activity_query_size to be of
> > size_t from int and fixes the issue.
>
> This cannot be backpatched, and using size_t is not really needed as
> track_activity_query_size is capped at 1MB. Why don't you just tweak
> the calculation done in pgstat_read_current_status() instead, say with
> a cast?
Thanks Michael, sure, that is probably a better alternative. I've attached v2.
BTW: CF entry is https://commitfest.postgresql.org/45/4592/
Regards,
-Jakub Wartak.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Cast-MemoryContextAllocHuge-calculations-in-pg_st.patch | application/octet-stream | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2023-09-27 09:00:36 | Re: Memory consumed by child SpecialJoinInfo in partitionwise join planning |
| Previous Message | Daniel Gustafsson | 2023-09-27 08:21:29 | Re: [PATCH] Add inline comments to the pg_hba_file_rules view |