| From: | Mahendra Singh Thalor <mahi6run(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_restore --format= option(without any value) should report an error as pg_dump is reporting an error |
| Date: | 2026-07-14 12:19:09 |
| Message-ID: | CAKYtNArLWuWqmrM05PKJcmeM1UPjcjtEZ=d82SnQSfMF-OXkkA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 20 Mar 2026 at 01:31, Mahendra Singh Thalor <mahi6run(at)gmail(dot)com> wrote:
>
> Thanks Nathan for committing this.
>
> Thanks and Regards
> Mahendra Singh Thalor
> EnterpriseDB: http://www.enterprisedb.com
>
>
> On Thu, 19 Mar 2026 at 12:54 AM, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>>
>> Committed.
>>
>> --
>> nathan
Hi Nathan,
This fix was committed as ec80215c033, but it got reverted along with
7ca548f23a6 (the revert of pg_dumpall's non-text output format support) as
collateral damage: the option-parsing block it touched had been restructured
by that feature, so the revert took this change down with it even though it
has nothing to do with non-text formats.
Re-attaching the same fix, unchanged, rebased on the current master.
We can back-port till v19.
--
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| pg_restore-Remove-unnecessary-strlen-calls-in-options-parsing.patch | text/x-patch | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan Gonzalez V. | 2026-07-14 12:19:32 | Re: pg_plan_advice: add NO_ scan and join method tags |
| Previous Message | Daniel Gustafsson | 2026-07-14 11:31:17 | Re: blkreftable.c needs more sanity checks |