pg_restore: TAP test case typo(wrong word) for an error hint in 001_basic.pl

From: Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: pg_restore: TAP test case typo(wrong word) for an error hint in 001_basic.pl
Date: 2026-03-15 17:29:53
Message-ID: CAKYtNArGv45WX3mpOrQ9p6+gb7FvA8qF14FB5pZfcDJ9PQrWKA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

While doing some changes, I found a typo error(wrong word) in 001_basic.pl
file.

In 31a8b77a9244a0883e1968adc, we added some test cases for pg_dump,
pg_restore and pg_dumpall.
In one error case, we added 'pg_dump' name instead of 'pg_rsetore'.

diff --git a/src/bin/pg_dump/t/001_basic.pl b/src/bin/pg_dump/t/001_basic.pl
index 9f12ca6c51d..ff1d422292e 100644
--- a/src/bin/pg_dump/t/001_basic.pl
+++ b/src/bin/pg_dump/t/001_basic.pl
@@ -144,7 +144,7 @@ command_fails_like(
command_fails_like(
[ 'pg_restore', '-f -', '-F', 'garbage' ],
qr/\Qpg_restore: error: unrecognized archive format "garbage";\E/,
- 'pg_dump: unrecognized archive format');
+ 'pg_restore: unrecognized archive format');

Here, I am attaching a patch to fix this.This patch can be applied till
PG14.

I think we should back-patch till PG14. Please review this.

--
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
v01-pg_restore-TAP-test-wrong-word-in-hint.patch text/x-patch 1.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mahendra Singh Thalor 2026-03-15 17:33:34 Re: pg_restore: remove unnecessary code from restore_all_databases function
Previous Message Andrey Borodin 2026-03-15 17:18:28 Re: Vacuum statistics