Re: Non-text mode for pg_dumpall

On Thu, 26 Feb 2026 at 19:32, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> On 2026-02-24 Tu 5:40 AM, Andrew Dunstan wrote:
> >
> > On 2026-02-24 Tu 2:21 AM, jian he wrote:
> >> Hi.
> >>
> >> For v19, the commit message
> >> """
> >> pg_restore is extended to handle these pg_dumpall archives, restoring
> >> globals and then each database. The --globals-only and --no-globals
> >> options control which parts are restored.
> >> """
> >> There is no --no-globals option.
> >>
> >> In file src/bin/pg_dump/pg_dumpall.c, no need
> >> ``
> >> static pg_compress_specification compression_spec = {0};
> >> ``
> >> Since compression_spec is only used in an IF branch, we can declare
> >> it locally.
> >>
> >>
> >> The options below are not supported for pg_restore non-text restore,
> >> we can document this.
> >> <option>-a/--data-only</option>,
> >> <option>-l/--list</option>,
> >> <option>-L/--use-list</option>,
> >> <option>--statistics-only</option>,
> >> <option>--strict-names</option>,
> >> <option>--no-schema</option>.
> >>
> >>
> >>
> >
> > Thanks, fixed these.
> >
> >
> >
>
>
> pushed with a slight tweak.
>
>
> cheers
>
>
> andrew
>
>
> --
> Andrew Dunstan
> EDB: https://www.enterprisedb.com
>

Thanks Andrew for committing this patch.

--
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com