| From: | Mahendra Singh Thalor <mahi6run(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: bug: pg_dumpall with --data-only and --clean options is giving an error after some dump |
| Date: | 2026-03-15 14:06:14 |
| Message-ID: | CAKYtNAp2L2nnC-7vdkEkkccDLmv22BH0wJyAzd3Z-M2ugYSEKQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks Andrew, Álvaro and Srinath for the review and feedback.
> 1) maybe match the pg_dumpall comment with the pg_dump comment.
I took this comment from pg_restore so i am keeping this same as pg_restore.
> 2) please fix the indentation using pgindent
> --
> Thanks,
> Srinath Reddy Sadipiralla
> EDB: https://www.enterprisedb.com/
Fixed.
On Sun, 15 Mar 2026 at 17:41, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> Hi,
>
> On 2026-Mar-15, Andrew Dunstan wrote:
>
> > On 2026-03-14 Sa 3:18 PM, Mahendra Singh Thalor wrote:
> >
> > > I was doing some tests with pg_dump, pg_dumpall and pg_restore tools.
> > > With "pg_dumpall --data-only --clean", we are reporting an error after
> > > dumping some data.
> >
> > Hmm, this looks like behaviour that goes a long way back. Should we
> > backpatch this fix?
>
> IMO it would make sense to do so.
>
> --
> Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
As per suggestions, I made patches till PG14.
Here, I am attaching updated patches.
--
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v02-master-pg_dumpall-clean-and-data-only-are-incompatible.patch | text/x-patch | 1.8 KB |
| v02-PG18-pg_dumpall-clean-and-data-only-are-incompatible.noci | application/octet-stream | 1.9 KB |
| v02-PG14-pg_dumpall-clean-and-data-only-are-incompatible.noci | application/octet-stream | 1.9 KB |
| v02-PG15-16-17-pg_dumpall-clean-and-data-only-are-incompatible.noci | application/octet-stream | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jelte Fennema-Nio | 2026-03-15 15:09:24 | Re: Don't use the deprecated and insecure PQcancel in our frontend tools anymore |
| Previous Message | Junwang Zhao | 2026-03-15 13:50:04 | Re: More speedups for tuple deformation |