| From: | Mahendra Singh Thalor <mahi6run(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Questions/Observations related to Gist vacuum |
| Date: | 2020-01-09 11:11:43 |
| Message-ID: | CAKYtNAoTDsc+Dgn2+A35v-YKt9qtXcjNMRhUo-3k8=UoAmwL+A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 9 Dec 2019 at 14:37, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Mon, Dec 9, 2019 at 2:27 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
wrote:
> >
> > I have modified the patch for the above points and additionally ran
> > pgindent. Let me know what you think about the attached patch?
> >
>
> A new version with a slightly modified commit message.
I reviewed v4 patch and below is the one review comment:
+ * These are used to memorize all internal and empty leaf pages. They
are
+ * used for deleting all the empty pages.
*/
After dot, there should be 2 spaces. Earlier, there was 2 spaces.
Other than that patch looks fine to me.
--
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Konstantin Knizhnik | 2020-01-09 11:17:08 | Re: [Proposal] Global temporary tables |
| Previous Message | Dagfinn Ilmari Mannsåker | 2020-01-09 11:03:23 | Re: Fixing parallel make of libpq |