Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement

On Fri, Nov 7, 2025 at 10:19 PM Manni Wood <manni(dot)wood(at)enterprisedb(dot)com>
wrote:

>
>
> On Fri, Nov 7, 2025 at 6:03 PM Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
> wrote:
>
>>
>>
>> On 08/11/2025 00:38, Manni Wood wrote:
>> > Alas, the build https://commitfest.postgresql.org/patch/6175/ <https://
>> > commitfest.postgresql.org/patch/6175/> now fails, and I cannot
>> reproduce
>> > on my machine. Obviously there will be a v9...
>>
>> You forgot the declaration for build_tablespace_ddl_string[1]:
>>
>> ruleutils.c:13755:1: warning: no previous prototype for
>> ‘build_tablespace_ddl_string’ [-Wmissing-prototypes]
>> 13755 | build_tablespace_ddl_string(const Oid tspaceoid)
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Best, Jim
>>
>> 1 - https://cirrus-ci.com/task/4855404196265984?logs=build#L1911
>>
>>
> Thank you very much, Jim. Serves me right for looking at the error at the
> end of the logs rather than the warning in the middle.
>
> v9 is attached.
> --
> -- Manni Wood EDB: https://www.enterprisedb.com
>

Ah, the error at the end of the logs is indeed still happening. Glad to
have gotten rid of that earlier warning, though.

https://cirrus-ci.com/task/6437176629526528?logs=build#L1906-L1912

I will ask for Nishant's help with this and post another patch.
--
-- Manni Wood EDB: https://www.enterprisedb.com