| From: | Manni Wood <manni(dot)wood(at)enterprisedb(dot)com> |
|---|---|
| To: | Nishant Sharma <nishant(dot)sharma(at)enterprisedb(dot)com> |
| Cc: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement |
| Date: | 2025-11-06 22:08:11 |
| Message-ID: | CAKWEB6obc_SB5Xj7NCMFQOoAeVX9LD8EvkvbtZXP9XTSe4OEiQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 5, 2025 at 5:54 AM Nishant Sharma <
nishant(dot)sharma(at)enterprisedb(dot)com> wrote:
> Thanks Álvaro for the review comments on v4!
>
> PFA, v5 patch set. I have included all your review comments.
>
>
> Regards,
> Nishant Sharma.
> EDB, Pune.
> https://www.enterprisedb.com
>
The BSD build was failing with the error 'WARNING: tablespaces created by
regression test cases should have names starting with "regress_"', so the
attached patches should fix that.
The windows build is also failing, on this error
"../src/port/strerror.c(311): fatal error C1051: program database file,
'C:\cirrus\build\src\port\libpgport_srv.pdb', has an obsolete format,
delete it and recompile", which I don't think is related to our patch.
--
-- Manni Wood EDB: https://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Supporting-changes-for-pg_get_tablespace_ddl-func.patch | text/x-patch | 6.3 KB |
| v6-0002-Adds-pg_get_tablespace_ddl-function.patch | text/x-patch | 14.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-11-06 22:13:33 | Re: [Patch] Windows relation extension failure at 2GB and 4GB |
| Previous Message | Robert Haas | 2025-11-06 21:57:02 | Tuesday at 2026.pgconf.dev |