Re: [PATCH] Keeps tracking the uniqueness with UniqueKey

From: Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, David Rowley <dgrowleyml(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, rushabh(dot)lathia(at)gmail(dot)com
Subject: Re: [PATCH] Keeps tracking the uniqueness with UniqueKey
Date: 2020-03-29 07:48:42
Message-ID: CAKU4AWrYPQaF0PsbJ4Vdj9-bT2fUKED14=T0q+w1Gm2ui01hCw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
>
>> Just update the patch which do some test case changes.
> 1. add "ANALYZE" command before running the explain.
> 2. order by with an explicit collate settings.
>

Thanks Rushabh for pointing this out, or else I'd spend much more time to
figure
out why I get a different order on Windows.

3. As for the postgres_fdw.sql, I just copied the results.out to
> expected.out,
> that's should be correct based on the result. However I added my comment
> around that.
>
> The issue doesn't exist at all. The confusion was introduced by a
misunderstanding
of the test case (I treated count (xx) filter (xxx) as a window function
rather than an aggration
function). so just fixed the it cleanly.

Some other changes made in the new patch:
1. Fixed bug for UniqueKey calculation for OUTER join.
2. Fixed some typo error in comments.
3. Renamed the field "grantee" as "guarantee".

Best Regards
Andy Fan

Attachment Content-Type Size
v3-0001-Maintain-UniqueKey-at-each-RelOptInfo-this-inform.patch application/octet-stream 88.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2020-03-29 07:51:49 Re: pg_stat_statements issue with parallel maintenance (Was Re: WAL usage calculation patch)
Previous Message Masahiko Sawada 2020-03-29 06:19:34 Re: pg_stat_statements issue with parallel maintenance (Was Re: WAL usage calculation patch)