Re: Would it be helpful for share the patch merge result from cfbot

From: Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Would it be helpful for share the patch merge result from cfbot
Date: 2020-10-23 02:01:14
Message-ID: CAKU4AWqj2WYBqOjpjJOWc=5KRJMOM2YB4ExNOFvgxoWib1gt6Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 23, 2020 at 9:58 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:

> On Fri, Oct 23, 2020 at 2:51 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
> wrote:
> > On Fri, Oct 23, 2020 at 2:32 PM Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com>
> wrote:
> > > Currently when people want to review a patch, they have to download /
> apply /
> > > maintain the branch manually. Would it be helpful that the reviewer
> can just
> > > git fetch a remote branch where all the things have been done already.
> I know
> > > that such cost saving is small, but it is a startup cost, so
> personally I think it is
> > > a good place to improve. Since we already maintain such remote git
> repo at cbfot,
> > > so can we just expose such URL for each item in commitfest then things
> would be done?
> > >
> > > At the bottom of cfbot, we have words "Please send feedback to thomas
> munro",
> > > so I added Tomas in the cc list.
> >
> > Hi Andy,
> >
> > Try this:
> >
> > git remote add cfbot https://github.com/postgresql-cfbot/postgresql.git
> > git fetch cfbot commitfest/30/2785
> > git checkout commitfest/30/2785
>
> Also, you might like this way of grabbing and applying all the patches
> from an archives link and applying them:
>
> $ cat ~/bin/fetch-all-patches.sh
> #!/bin/sh
> for P in ` curl -s $1 | grep "\.patch" | sed 's|^ *<a
> href="|https://www.postgresql.org|;s|".*||' ` ; do
> echo $P
> curl -s -O $P
> done
> $ ~/bin/fetch-all-patches.sh
> '
> https://www.postgresql.org/message-id/20200718201532.GV23581@telsasoft.com
> '
>
> https://www.postgresql.org/message-id/attachment/112541/v21-0001-Document-historic-behavior-of-links-to-directori.patch
>
> https://www.postgresql.org/message-id/attachment/112542/v21-0002-pg_stat_file-and-pg_ls_dir_-to-use-lstat.patch
>
> https://www.postgresql.org/message-id/attachment/112543/v21-0003-Add-tests-on-pg_ls_dir-before-changing-it.patch
>
> https://www.postgresql.org/message-id/attachment/112544/v21-0004-Add-pg_ls_dir_metadata-to-list-a-dir-with-file-m.patch
>
> https://www.postgresql.org/message-id/attachment/112545/v21-0005-pg_ls_tmpdir-to-show-directories-and-isdir-argum.patch
>
> https://www.postgresql.org/message-id/attachment/112546/v21-0006-pg_ls_-dir-to-show-directories-and-isdir-column.patch
>
> https://www.postgresql.org/message-id/attachment/112547/v21-0007-Add-pg_ls_dir_recurse-to-show-dir-recursively.patch
>
> https://www.postgresql.org/message-id/attachment/112548/v21-0008-pg_ls_logdir-to-ignore-error-if-initial-top-dir-.patch
>
> https://www.postgresql.org/message-id/attachment/112549/v21-0009-pg_ls_-dir-to-return-all-the-metadata-from-pg_st.patch
>
> https://www.postgresql.org/message-id/attachment/112550/v21-0010-pg_ls_-to-show-file-type-and-show-special-files.patch
> $ git am v21-*.patch
>

This is exactly what I want and more than that. Thank you Thomas!

--
Best Regards
Andy Fan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-10-23 02:01:25 Re: new heapcheck contrib module
Previous Message Mark Dilger 2020-10-23 01:59:03 Re: new heapcheck contrib module