| From: | "Brightwell, Adam" <adam(dot)brightwell(at)crunchydatasolutions(dot)com> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [TODO] Track number of files ready to be archived in pg_stat_archiver |
| Date: | 2014-10-21 15:50:41 |
| Message-ID: | CAKRt6CTTBO_NPxuo3=iuTBaFyt6z99Oj_6_BwQi5OhZEMia1+Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Julien,
> Actually, I used the same loop as the archiver one (see
> backend/postmaster/pgarch.c, function pgarch_readyXlog) to get the exact
> same number of files.
>
Ah, I see.
> If we change it in this patch, it would be better to change it everywhere.
> What do you think ?
>
Hmm... I'd have to defer to the better judgement of a committer on that
one. Though, I would think that the general desire would be to keep the
patch relevant ONLY to the necessary changes. I would not qualify making
those types of changes as relevant, IMHO. I do think this is potential for
cleanup, however, I would suspect that would be best done in a separate
patch. But again, I'd defer to a committer whether such changes are even
necessary/acceptable.
-Adam
--
Adam Brightwell - adam(dot)brightwell(at)crunchydatasolutions(dot)com
Database Engineer - www.crunchydatasolutions.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-10-21 15:52:09 | Re: Deferring some AtStart* allocations? |
| Previous Message | Florian Pflug | 2014-10-21 15:04:49 | Re: Question about RI checks |