| From: | Adam Brightwell <adam(dot)brightwell(at)crunchydatasolutions(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Unnecessary #include in objectaddress.h? |
| Date: | 2015-07-20 23:05:41 |
| Message-ID: | CAKRt6CSQaxKXvb-rc6C6rV0aUSWU+Fzj-AKXjF0_hMuwZPyOCg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> I wondered whether to bother about this kind of thing for a while. It
> doesn't have any practical impact immediately, because obviously
> pg_list.h is still included indirectly by objectaddress.h (via lock.h in
> this case IIRC). If we made some restructuring that caused the other
> header not to include pg_list.h anymore, that would make objectaddress.h
> broken -- unless objectaddress.h itself no longer needed pg_list.h.
>
> We've had in previous rounds whole iterations on a "pgrminclude" script
> that does this kind of thing, but the breakage after each such run is
> large.
>
> All in all, I wouldn't bother unless there is an actual change.
Understood. Thanks.
-Adam
--
Adam Brightwell - adam(dot)brightwell(at)crunchydatasolutions(dot)com
Database Engineer - www.crunchydatasolutions.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2015-07-21 02:29:43 | Re: creating extension including dependencies |
| Previous Message | Adam Brightwell | 2015-07-20 23:01:14 | Re: security labels on databases are bad for dump & restore |