| From: | Adam Brightwell <adam(dot)brightwell(at)crunchydatasolutions(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: CATUPDATE confusion? |
| Date: | 2015-02-19 23:08:09 |
| Message-ID: | CAKRt6CQmJ1PXh+FSzxwQFu5PT2=sQkNpGER7QUP=uL0Ob_Jhig@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter,
Thanks for the review and feedback.
> One of the interesting behaviors (or perhaps not) is how
> > 'pg_class_aclmask' handles an invalid role id when checking permissions
> > against 'rolsuper' instead of 'rolcatupdate'.
>
> I'd get rid of that whole check, not just replace rolcatupdate by rolsuper.
>
Ah yes, that's a good point. I have updated and attached a new version of
the patch.
Thanks,
Adam
--
Adam Brightwell - adam(dot)brightwell(at)crunchydatasolutions(dot)com
Database Engineer - www.crunchydatasolutions.com
| Attachment | Content-Type | Size |
|---|---|---|
| remove-catupdate-v2.patch | application/octet-stream | 10.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2015-02-19 23:39:45 | Re: Allow "snapshot too old" error, to prevent bloat |
| Previous Message | David Fetter | 2015-02-19 22:33:28 | Re: POLA violation with \c service= |