| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Adam Brightwell <adam(dot)brightwell(at)crunchydatasolutions(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: CATUPDATE confusion? |
| Date: | 2015-02-25 05:53:55 |
| Message-ID: | CAB7nPqQqDypK52VThzS9-jj+k83bKUYN4rv4g8NCiG+Fv1SSsQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 20, 2015 at 8:08 AM, Adam Brightwell <
adam(dot)brightwell(at)crunchydatasolutions(dot)com> wrote:
> Thanks for the review and feedback.
>
> > One of the interesting behaviors (or perhaps not) is how
>> > 'pg_class_aclmask' handles an invalid role id when checking permissions
>> > against 'rolsuper' instead of 'rolcatupdate'.
>>
>> I'd get rid of that whole check, not just replace rolcatupdate by
>> rolsuper.
>>
>
> Ah yes, that's a good point. I have updated and attached a new version of
> the patch.
>
I just had a look at this patch and it works as intended, simply removing
catupdate and all its code paths. As everybody on this thread seems to
agree about the removal of rolcatupdate, I think that we could let a
committer have a look at it.
Thoughts?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-02-25 05:56:30 | Re: Precedence of standard comparison operators |
| Previous Message | Andreas Karlsson | 2015-02-25 04:14:56 | Fix autoconf deprecation warnings |