Re: [Patch] New pg_stat_tablespace view

From: Ahmed Gouda <ahmed(dot)gouda(at)cybertec(dot)at>
To: shihao zhong <zhong950419(at)gmail(dot)com>
Cc: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, songjinzhou <tsinghualucky912(at)foxmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, jian he <jian(dot)universality(at)gmail(dot)com>
Subject: Re: [Patch] New pg_stat_tablespace view
Date: 2026-09-11 08:13:55
Message-ID: CAKR6JgdmyYwN_WExQYUn79FccvrVrF3_rgSnfoAkDX2qBvAAGw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Shihao,

I am having a problem building the v5 patch locally. I get the following
compile errors:

```
pgstat_relation.c: In function ‘pgstat_relation_flush_cb’:
pgstat_relation.c:1009:64: error: ‘PgStat_TableCounts’ has no member named
‘tuples_inserted’; did you mean ‘tuples_returned’?
1009 | tsentry->tuples_inserted +=
lstats->tab.counts.tuples_inserted;
|
^~~~~~~~~~~~~~~
|
tuples_returned
pgstat_relation.c:1010:62: error: ‘PgStat_TableCounts’ has no member named
‘tuples_updated’
1010 | tsentry->tuples_updated +=
lstats->tab.counts.tuples_updated;
| ^
pgstat_relation.c:1011:63: error: ‘PgStat_TableCounts’ has no member named
‘tuples_deleted’; did you mean ‘tuples_fetched’?
1011 | tsentry->tuples_deleted +=
lstats->tab.counts.tuples_deleted;
|
^~~~~~~~~~~~~~
|
tuples_fetched
```

I believe these entries should be updated to use
`lstats->tab.counts_xact....`??

See:
https://github.com/postgres/postgres/commit/3f2f5e7c4cc5a917e77a3d5a0c4353b702aa7307

Regards

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2026-09-11 08:27:28 Re: Review items for EXCEPT TABLE publication
Previous Message Fujii Masao 2026-09-11 08:06:30 Re: pg_createsubscriber does not check output_plugin_libraries