Re: pg_upgrade: prep_status doesn't translate messages

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_upgrade: prep_status doesn't translate messages
Date: 2019-06-11 03:05:01
Message-ID: CAKPRHzJSZM5XABaey6MMia3R=3Wp0eKaJ7BRm2k6QyeaFCo85Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello.

At Mon, 10 Jun 2019 16:48:42 +0900, Michael Paquier
<michael(at)paquier(dot)xyz> wrote in <20190610074842(dot)GH2199(at)paquier(dot)xyz>
> On Mon, Jun 10, 2019 at 01:57:14PM +0900, Kyotaro Horiguchi wrote:
> > If we don't do that, translation lines in po files are
> > useless. prep_stauts must be removed from TETTEXT_TRIGGERS, and a
> > comment that explains the reason for not translating.
> >
> > Any opinions?
>
> I agree with your point that it should be an all-or-nothing, and not
> something in the middle. Now, I would fall into the category of
> people which would prefer making the full set of contents translated,

I'm on the same side. Whether do you think this as a 12-issue or
for later versions? I think there is no risk in changing it now so
I wish the change is contained in 12-shipping.

> and there has been some work in this area recently:
> https://www.postgresql.org/message-id/20170523002827.lzc2jkzh2gubclqb@alvherre.pgsql

Thanks for the pointer. I'm seeing the result of the discussion
now. Apart from the discussion of translate-or-not decision,
there can be a discussion how we can reduce the burden of
translation work. I was a bit tired to translate something like
the followings:

old and new pg_controldata block sizes are invalid or do not match
old and new pg_controldata maximum relation segment sizes are invalid
or do not match
old and new pg_controldata WAL block sizes are invalid or do not match
...

I'm not sure where is the compromisable point between burden of
translators and programmers, though.

regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-06-11 03:22:49 rebased background worker reimplementation prototype
Previous Message Amit Langote 2019-06-11 02:52:52 Re: Should we warn against using too many partitions?