Re: Eval expression R/O once time (src/backend/executor/execExpr.c)

From: Artur Zakirov <zaartur(at)gmail(dot)com>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Eval expression R/O once time (src/backend/executor/execExpr.c)
Date: 2021-10-01 09:55:37
Message-ID: CAKNkYnzY7re-WHWo3prJoi7Y_kJmMFoemUA9RzYrE1caQ5osAw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 22, 2021 at 1:12 AM Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
> Anyway, the v1 patch fixes only the expression eval.

The patch looks good to me.

It seems that initially the code looked similar to your patch. See the
commit b8d7f053c5c2bf2a7e8734fe3327f6a8bc711755. Then the variables
were moved to foreach scope by the commit
1ec7679f1b67e84be688a311dce234eeaa1d5de8.

I'll mark the patch as Ready for Commiter.

--
Artur

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2021-10-01 10:04:03 Re: Eval expression R/O once time (src/backend/executor/execExpr.c)
Previous Message Kyotaro Horiguchi 2021-10-01 09:12:05 Re: Logical replication keepalive flood