| From: | Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [BUG?] pg_event_trigger_ddl_commands() error with ALTER TEXT SEARCH CONFIGURATION |
| Date: | 2016-12-21 22:07:11 |
| Message-ID: | CAKNkYnxzucx0Mt6UcyOSOYejSuC16=+0nr0mTc-_692mFFsthg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thank you for your comments, Stephen.
2016-12-21 20:34 GMT+03:00 Stephen Frost <sfrost(at)snowman(dot)net>:
>
> Did you happen to look at adding a regression test for this to
> test_ddl_deparse?
Of course. I updated the patch.
>
>> This patch only fixes the bug. But I think I also can do a patch which
>> will give pg_ts_config_map entries with
>> pg_event_trigger_ddl_commands() if someone wants. It can be done using
>> new entry in the CollectedCommandType structure maybe.
>
> While that sounds like a good idea, it seems like it's more a feature
> addition rather than a bugfix, no?
>
Yes, agree with you. It should be added as a separate patch. I think I
will deal with it.
--
Artur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| event-trigger-ts-config-map-v2.patch | text/x-patch | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-12-21 22:35:25 | Re: Speedup twophase transactions |
| Previous Message | Peter Geoghegan | 2016-12-21 21:48:09 | Re: Parallel tuplesort (for parallel B-Tree index creation) |