Re: PATCH: Added Statistics functionality for many nodes (pgAdmin4)

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Added Statistics functionality for many nodes (pgAdmin4)
Date: 2016-06-15 07:06:59
Message-ID: CAKKotZQt5JsPvTzLZVT9ahGM2WKEych95gDaK4qg_3Fy02ztRg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

PFA patch to add stats on Sequences/Function/Trigger functions collection
nodes.
Please review.

Regards,
Murtuza

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jun 14, 2016 at 1:49 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> I copied pgAdmin3 behaviour, I’ll implement it in pgAdmin4 :)
>
> Thanks,
> Murtuza
>
> > On 13-Jun-2016, at 5:51 pm, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> >
> > On Mon, Jun 13, 2016 at 12:29 PM, Murtuza Zabuawala
> > <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> >> The strange effects that leads to.
> >>
> >>
> >>> On 13-Jun-2016, at 4:55 pm, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> >>>
> >>> Hi
> >>>
> >>> On Mon, Jun 13, 2016 at 12:18 PM, Murtuza Zabuawala
> >>> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> >>>> Hi Dave,
> >>>>
> >>>> I tried with fresh install of 9.4 version but still not able to
> re-produce the issue, I also tried switching python version 2.7/3.5 but
> still no luck.
> >>>> I also checked with Neel & Surinder on their system but still not
> able to re-produce the issue.
> >>>
> >>> What can't you reproduce - the queries returning zero rows, or the
> >>> strange effects that leads to?
> >
> > Hmm, neither can I now. I wonder if something didn't refresh correctly...
> >
> > I do notice that we don't return stats for the Sequences, Trigger
> > functions or Functions nodes though.
> >
> >
> > --
> > Dave Page
> > Blog: http://pgsnake.blogspot.com
> > Twitter: @pgsnake
> >
> > EnterpriseDB UK: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
>
>

Attachment Content-Type Size
Added_Stats_on_collection_nodes.patch application/octet-stream 23.9 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Surinder Kumar 2016-06-15 07:21:12 Re: pgAdmin 4 commit: Fix query tool horizontal scrolling of results. Fixes
Previous Message Surinder Kumar 2016-06-15 05:18:57 Re: Qt runtime issue on python 3 + patch