Re: Add ldapservice connection parameter

From: Andrew Jackson <andrewjackson947(at)gmail(dot)com>
To: Roman Khapov <rkhapov(at)yandex-team(dot)ru>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add ldapservice connection parameter
Date: 2026-01-12 23:53:14
Message-ID: CAKK5BkFxWnddC2=mbHpojWnOLe=x3vLftaMUkO3ocJwqZN7Tug@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Steven and Roman, Thank you for the review.

Here is an updated patch that addresses both of these issues.

On Mon, Jan 12, 2026 at 4:06 AM Roman Khapov <rkhapov(at)yandex-team(dot)ru> wrote:
>
> Hi!
>
> Thanks for your patch!
>
> Adding to the one Steven wrote, I noticed one typo in the patch:
>
> @@ -2337,7 +2337,7 @@ postgresql://%2Fvar%2Flib%2Fpostgresql/dbname
> <term><literal>ldapservice</literal></term>
> <listitem>
> <para>
> - This option specifies an LDAP query that can be used to reference connection paremeters
> + This option specifies an LDAP query that can be used to reference connection parameters
> stored in an LDAP server. This functionality is described in more detail in <xref linkend="libpq-ldap"/>.
> </para>
>
> paremeters -> parameters
>
> --
> Best regards,
> Roman Khapov

Attachment Content-Type Size
0001-Add-ldapservice-connection-parameter.patch text/x-patch 4.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2026-01-12 23:58:49 Re: Adding basic NUMA awareness
Previous Message Andres Freund 2026-01-12 23:22:37 Re: Buffer locking is special (hints, checksums, AIO writes)